Update Rust crate temporalio-common to ef57d63#8421
Update Rust crate temporalio-common to ef57d63#8421hash-worker[bot] wants to merge 1 commit intomainfrom
temporalio-common to ef57d63#8421Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 1b0baaf. Bugbot is set up for automated code reviews on this repo. Configure here. |
github-actions
bot
added
the
area/deps
🤖 Augment PR SummarySummary: This PR updates the pinned git revision for the Rust crate Changes:
Technical Notes: Since both crates come from the same upstream repository, mixing revisions may result in multiple git checkouts/duplicate crate versions unless they are intentionally kept independent. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| temporalio-client = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "fb14d9c3cf4e9e6d0894fd9bb2985dbf6d6de1fe" } | ||
| test-log = { version = "0.2.18", default-features = false } |
There was a problem hiding this comment.
temporalio-common is now pinned to a different git rev than temporalio-client (same upstream repo), which can cause Cargo to pull two distinct copies and potentially lead to type/version mismatches. Is it expected that these two crates are compatible across different commits, or should they be bumped together to the same rev?
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8421 +/- ##
==========================================
- Coverage 62.50% 62.50% -0.01%
==========================================
Files 1318 1318
Lines 134219 134219
Branches 5518 5518
==========================================
- Hits 83895 83893 -2
- Misses 49409 49411 +2
Partials 915 915
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
58f81bb to
b8b4e23
Compare
hash-worker
bot
changed the title
temporalio-common to fb14d9ctemporalio-common to 20a6817
hash-worker
bot
changed the title
temporalio-common to 20a6817temporalio-common to 12c656f
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
b8b4e23 to
b67cdc2
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Cargo.toml
Outdated
| tarpc = { version = "0.36.0", default-features = false, git = "https://github.com/google/tarpc", rev = "f55f36d2d876b1868cfcf52f41d0456a60cf726c" } | ||
| temporalio-client = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "12c656f7b2dce2a139bb3f1b4873c7007a751380" } |
There was a problem hiding this comment.
Temporal SDK revisions are now inconsistent
Medium Severity
temporalio-client stays on rev 231e21c while temporalio-common is bumped to 12c656f..., so the workspace now resolves two different temporalio-common crates. This can break interoperability where hash-temporal-client uses both crates, because shared SDK types may no longer be identical across crate boundaries.
Additional Locations (1)
hash-worker
bot
changed the title
temporalio-common to 12c656ftemporalio-common to f16f160
hash-worker
bot
changed the title
temporalio-common to 21e03c2temporalio-common to 2014f31
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
133dd13 to
694fa8b
Compare
hash-worker
bot
changed the title
temporalio-common to 2014f31temporalio-common to a0caec4
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
694fa8b to
c7fbc51
Compare
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
c7fbc51 to
9ff8edf
Compare
hash-worker
bot
changed the title
temporalio-common to a0caec4temporalio-common to 9d678b9
hash-worker
bot
changed the title
temporalio-common to 9d678b9temporalio-common to 78a94de
hash-worker
bot
force-pushed
the
deps/rs/temporalio-common-digest
branch
from
9ff8edf to
34cbc3a
Compare
hash-worker
bot
changed the title
temporalio-common to 78a94detemporalio-common to 7161ed3
2 participants
This PR contains the following updates:
231e21c->ef57d63Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - "before 4am every weekday,every weekend" (UTC).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.